Creation of the zip folder of the Insights produced (and get_timesoap)#124
Merged
Conversation
andrewtarzia
requested changes
Oct 10, 2025
andrewtarzia
left a comment
andrewtarzia
left a comment
Collaborator
There was a problem hiding this comment.
Big fan. Minor changes. Nice work!
Key is to write a test that will make a zip file, load it back in and ensure everything is the same as the data put in or as expected.
Collaborator
|
Everything else looks good to me :) |
andrewtarzia
requested changes
Oct 31, 2025
andrewtarzia
left a comment
andrewtarzia
left a comment
Collaborator
There was a problem hiding this comment.
There were open comments from my last review still. Plus a few other considerations,
SimoneMartino98
marked this pull request as ready for review
November 10, 2025 14:07
andrewtarzia
requested changes
Nov 10, 2025
Collaborator
|
Having both |
Collaborator
Author
|
I explained this in the documentation. It was the only way to have an autosummary But I think there is a better way to proceed. Maybe in the future version of the logger. |
matteobecchi
approved these changes
Nov 13, 2025
matteobecchi
approved these changes
Nov 13, 2025
andrewtarzia
approved these changes
Nov 13, 2025
This was referenced Nov 14, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone;
As in the title, here to add a logger functionality to create a zip archive at the end of a
dynsightpipeline.Also adding the
get_timesoapmethod.Absolutely conscious about the possible risks of such a method, that's why I'm putting this as a draft to collect suggestions.